From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Fri, 14 Sep 2012 16:16:36 +0000 (+0200)
Subject: MessageTray: remove bad fast path in hideSummaryBoxPointer
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5863
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=7654f1ca3ef4dbe8f61a6562bd9585ad13b01780;p=gnome-shell.git

MessageTray: remove bad fast path in hideSummaryBoxPointer

The onUngrab callback already checks if all notifications are destroyed and
hides immediately if so. Previous code instead would leave state handling
in an inconsistent state, by not removing the grab, not setting
summaryBoxPointerState to HIDDEN and not disconnecting various signals.

https://bugzilla.gnome.org/show_bug.cgi?id=684036
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 1b6409871..21687ee06 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2436,14 +2436,6 @@ const MessageTray = new Lang.Class({
     },
 
     _hideSummaryBoxPointer: function() {
-        // We should be sure to hide the box pointer if all notifications in it are destroyed while
-        // it is hiding, so that we don't show an animation of an empty blob being hidden.
-        if (this._summaryBoxPointerState == State.HIDING &&
-            this._summaryBoxPointerItem.notificationStack.get_n_children() == 0) {
-            this._summaryBoxPointer.actor.hide();
-            return;
-        }
-
         this._grabHelper.ungrab({ actor: this._summaryBoxPointer.bin.child });
     },